Add als executable as dependency of test-suite#43
Draft
juliapath wants to merge 1 commit intoagda:masterfrom
Draft
Add als executable as dependency of test-suite#43juliapath wants to merge 1 commit intoagda:masterfrom
juliapath wants to merge 1 commit intoagda:masterfrom
Conversation
juliapath
force-pushed
the
test-build-tool-depends
branch
from
6df6462 to
afc0c14
Compare
This will make it available via PATH, when running cabal test, so that we do not need to manually point the test suiet at the executable with the --als-path test option.
juliapath
force-pushed
the
test-build-tool-depends
branch
from
afc0c14 to
f8f04a6
Compare
Member
|
Thanks, this looks useful. I don’t expect this to interfere with our current workflows in any major way. Our CI is still Stack-based, so this change is mainly relevant for cabal test / Nix-style builds rather than the existing CI path. So yes, I think this is worth pursuing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I want to fix #33, so that this just works under nix, ideally without requiring any special treatment on the nix side. There are currently two problems stopping the package from building (without providing specific configuration):
This addresses the second one by making cabal add the als executable to PATH when running cabal test.
To be honest, I don't know how thiss interacts with other workflows, so I'm waiting to see if the GitHub Actions go through and for your comment. :)