Update project base to comply with Block's new infosec rules #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedronveloso
requested review from
ScottAntonacAP and
benfterpay
as code owners
this was added in an attempt to get the build script running according to docs this option saves compile time at the expense of type accuracy. Given that compile time is fast at the moment, will revert this.
eslint was downgraded in an attempt to get the lint script running, but this was not where the problem lay. now that linting is running correctly it can be upgraded again
ScottAntonacAP
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We (Block employees) can't use the public NPM repository for laptop or CI compilation anymore - per infosec new rules. The project was failing to pull dependencies to install (it would still work if you had them cached locally). A possible solution would be to use Square's internal NPM registry, but that would break it for other users since this is a public repository.
So as an alternative, I've removed the local configuration files, for a regular user this will default to public repos, and for Block employees I've added a note to follow extra setup instructions.