Replace Clock instance by Timer instance (three r183+)#5800
Open
vincentfretin wants to merge 1 commit intoaframevr:masterfrom
Open
Replace Clock instance by Timer instance (three r183+)#5800vincentfretin wants to merge 1 commit intoaframevr:masterfrom
vincentfretin wants to merge 1 commit intoaframevr:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace Clock instance by Timer instance. Clock is deprecated in three r183.
To be merged after the repo is updated to three r183+
I didn't call
self.timer.connect(document);The
connect(document)call on the timer leverages the Page Visibility API similar to Clock to prevent large time jumps when the browser tab is inactive.I don't think we want it?
FYI networked-aframe accessed that clock instance so I did some changes in networked-aframe/networked-aframe#521 That's the only occurrence of it I saw in community components.