Skip to content

Remove renderer colorManagement: true in examples, that's the default #5799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dmarcos merged 1 commit into from
Mar 30, 2026
Merged

Remove renderer colorManagement: true in examples, that's the default #5799

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions examples/animation/aframe-logo/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,7 @@
</head>
<body>
<a-scene xr-mode-ui="enabled: false;"
background="color: #24CAFF;"
renderer="colorManagement: true;">
background="color: #24CAFF;">
<a-assets>
<a-asset-item id="treeModel" src="../../assets/models/tree1.glb"></a-asset-item>
<a-mixin
Expand Down
2 changes: 1 addition & 1 deletion examples/boilerplate/ar-hello-world/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
<a-scene
reflection="directionalLight: a-light[type=directional]"
ar-hit-test="target: #objects;"
renderer="colorManagement: true; exposure: 1; toneMapping: ACESFilmic"
renderer="exposure: 1; toneMapping: ACESFilmic"
shadow="type: pcfsoft"
xr-mode-ui="XRMode: xr"
>
Expand Down
1 change: 0 additions & 1 deletion examples/mixed-reality/anchor/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
<body>
<a-scene
obb-collider="showColliders: false"
renderer="colorManagement: true;"
button
xr-mode-ui="XRMode: ar"
info-message="htmlSrc: #messageText">
Expand Down
1 change: 0 additions & 1 deletion examples/mixed-reality/real-world-meshing/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
<a-scene
real-world-meshing="filterLabels: table; meshesEnabled: false; planeMixin: xrplane"
obb-collider="showColliders: false"
renderer="colorManagement: true;"
xr-mode-ui="XRMode: ar"
info-message="htmlSrc: #messageText">
<a-assets>
Expand Down
2 changes: 1 addition & 1 deletion examples/mixed-reality/watch/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
<a-scene
button
obb-collider="showColliders: false"
renderer="colorManagement: true; sortTransparentObjects: true"
renderer="sortTransparentObjects: true"
xr-mode-ui="XRMode: xr"
info-message="htmlSrc: #messageText; startOpened: true">
<a-assets timeout="10000">
Expand Down
2 changes: 1 addition & 1 deletion examples/primitives/models/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<script src="../../../dist/aframe-master.js"></script>
</head>
<body>
<a-scene renderer="colorManagement: true;">
<a-scene>
<a-assets>
<a-asset-item id="tree1" src="../../assets/models/tree1.glb"></a-asset-item>
<a-asset-item id="tree2" src="../../assets/models/tree2.glb"></a-asset-item>
Expand Down
2 changes: 1 addition & 1 deletion examples/showcase/anime-UI/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
<script src="https://unpkg.com/aframe-event-set-component@5.x.x/dist/aframe-event-set-component.min.js"></script>
</head>
<body>
<a-scene renderer="colorManagement: true;" xr-mode-ui="XRMode: xr">
<a-scene xr-mode-ui="XRMode: xr">
<a-assets>
<a-asset-item id="engine" src="models/engine.glb"></a-asset-item>
<a-mixin id="image" geometry="height: 2; width: 2"></a-mixin>
Expand Down
2 changes: 1 addition & 1 deletion examples/showcase/composite/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<script src="../../../dist/aframe-master.js"></script>
</head>
<body>
<a-scene renderer="colorManagement: true;">
<a-scene>
<a-assets>
<img id="lake" src="lake.jpg">
<img id="pdx" src="portland.png">
Expand Down
1 change: 0 additions & 1 deletion examples/showcase/model-viewer/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
<body>

<a-scene
renderer="colorManagement: true;"
info-message="htmlSrc: #messageText"
model-viewer="gltfModel: #triceratops; title: Triceratops"
xr-mode-ui="XRMode: xr">
Expand Down
2 changes: 1 addition & 1 deletion examples/showcase/shopping/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<script src="../../../dist/aframe-master.js"></script>
</head>
<body>
<a-scene background="color: #ECECEC" renderer="colorManagement: true;">
<a-scene background="color: #ECECEC">
<a-assets>
<a-asset-item id="why-male-models" src="man.glb"></a-asset-item>
<img id="fall" src="fall.png">
Expand Down
1 change: 0 additions & 1 deletion examples/showcase/tracked-controls/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
</head>
<body>
<a-scene
renderer="colorManagement: true;"
cursor="rayOrigin: mouse"
raycaster="objects: [cube]" fog="color: #bc483e; near: 0; far: 65;">
<a-assets>
Expand Down
2 changes: 1 addition & 1 deletion examples/test/model/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<script src="../../../dist/aframe-master.js"></script>
</head>
<body>
<a-scene gltf-model="basisTranscoderPath:https://cdn.jsdelivr.net/npm/three@0.154.0/examples/jsm/libs/basis/;" background="color: #FAFAFA" renderer="colorManagement: true;" stats>
<a-scene gltf-model="basisTranscoderPath:https://cdn.jsdelivr.net/npm/three@0.154.0/examples/jsm/libs/basis/;" background="color: #FAFAFA" stats>
<a-assets>
<a-asset-item id="crate-obj" src="../../assets/models/crate/crate.obj"></a-asset-item>
<a-asset-item id="crate-mtl" src="../../assets/models/crate/crate.mtl"></a-asset-item>
Expand Down
Loading