Skip to content

feat(hand-controls): fix hand model rotation alignment#5766

Merged
dmarcos merged 1 commit intoaframevr:masterfrom
filandra:add-rotation-position-hand-controls
Mar 28, 2026
Merged

feat(hand-controls): fix hand model rotation alignment#5766
dmarcos merged 1 commit intoaframevr:masterfrom
filandra:add-rotation-position-hand-controls

Conversation

@filandra
Copy link
Copy Markdown
Contributor

@filandra filandra commented Dec 7, 2025

Description:
Default rotation and position is aligned with Meta Quest Controllers.
The adjustment for Pico4 has been removed.
It set the handModelOrientationX to -45 degrees, which now is the default value. As a result this adjustment is not needed anymore.

@filandra filandra force-pushed the add-rotation-position-hand-controls branch from f0df2a7 to b64fbe2 Compare December 7, 2025 22:57
@filandra
Copy link
Copy Markdown
Contributor Author

filandra commented Dec 7, 2025

This change is addressing issues: #5570, #5305, #5321

@dmarcos
Copy link
Copy Markdown
Member

dmarcos commented Dec 7, 2025

Thanks. If any rotation is needed the rotation should be handled internally or hand-controls is not working properly.

@filandra
Copy link
Copy Markdown
Contributor Author

@dmarcos sorry for the delay - the holidays were very busy hahah. What do you mean by internally? Should it be handled in some other module? I figured that I would place the rotation handling into the same place where it was being already modified previously.

@vincentfretin
Copy link
Copy Markdown
Contributor

@filandra This means removing offSetRotation offSetPosition properties you added, put back the offset directly in radians inline in the code, so Math.PI / 4 for everything.

@filandra
Copy link
Copy Markdown
Contributor Author

@vincentfretin Well the whole point of the PR is to add the ability to set custom rotation and position. If not here, where should this logic be added?

@vincentfretin
Copy link
Copy Markdown
Contributor

The rotation is wrong on all Quest headsets right? After you fix the rotation inline in the component, why would you need to customize it?

@dmarcos
Copy link
Copy Markdown
Member

dmarcos commented Jan 28, 2026

Yeah we should just fix the rotation. No need of a public API

@filandra filandra force-pushed the add-rotation-position-hand-controls branch from b64fbe2 to 6469a86 Compare March 23, 2026 23:34
@filandra filandra changed the title Add rotation and position parameters to hand-controls. feat(hand-controls): Fix hand model rotation alignment Mar 23, 2026
@filandra filandra changed the title feat(hand-controls): Fix hand model rotation alignment feat(hand-controls): fix hand model rotation alignment Mar 23, 2026
@filandra filandra force-pushed the add-rotation-position-hand-controls branch from 6469a86 to 9c8252b Compare March 23, 2026 23:41
@filandra
Copy link
Copy Markdown
Contributor Author

@dmarcos @vincentfretin I believe now the implementation should be correct?

@vincentfretin
Copy link
Copy Markdown
Contributor

Yes, that's correct, thanks. I tested on the showcase/tracked-controls/index.html example, with lowPoly, highPoly and toon hands on my Quest 3, hands position are correct with that change. @dmarcos good to merge, you can also close the linked issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants