fixed website crash error by highscores#134
Open
Yash-Punia wants to merge 1 commit intoaframevr:masterfrom
Open
fixed website crash error by highscores#134Yash-Punia wants to merge 1 commit intoaframevr:masterfrom
Yash-Punia wants to merge 1 commit intoaframevr:masterfrom
Conversation
vladern
approved these changes
Sep 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Error: The official A-Blast website crashes on opening because of some null value error in
highscores.jsfile as of now.Cause: The
document.getElementById('save-score')was returning the null value which in turn crashed the codeSolution: I added a window.onload function to solve the error such that the dom request is made only after the window is loaded