Conversation
The me_tag option does nothing that couldn't be done with the tags option that works on all Filters. Recommend using tags instead of me_tag in the documentation and drop the custom handle_message. Add some code to make existing rules work as expected. As a side-effect this makes [MeFilter] tags = -something work as expected. It used to do nothing, now it removes the something tag.
Instead of accepting only tags_blacklist just pass everything but me_tags to the super class's init function. This way the message can be overwritten in the config which up to now yields an exception: TypeError: __init__() got an unexpected keyword argument 'message'
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #271 +/- ##
==========================================
- Coverage 40.51% 40.40% -0.11%
==========================================
Files 30 30
Lines 980 980
==========================================
- Hits 397 396 -1
- Misses 583 584 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hello @ukleinek
Yes actually there was some significant progress on the tests side of the project, I will comment the diff. |
|
Also ping @aidecoe original author of this filter |
|
Hi ukleinek. What is the improvement? Or is it just a code refactor? |
3 participants
Note this is completely untested, so please look deeply before merging :-)