fix(gui): make CAT per-port enable toggle visible#3618
Open
K5PTB wants to merge 1 commit into
Open
Conversation
Users were missing that each CAT port has its own enable checkbox — the "En" header read as truncated and the default checkbox indicator is nearly invisible against the dark applet/popout background. - Relabel the column header "En" -> "Enabled" (widened + centered) in both the floating applet and the pop-out window. - Style the enable QCheckBox indicator for dark mode: high-contrast border when unchecked, filled accent when checked, plus an "Enable this CAT port" tooltip. Applet uses theme tokens; popout uses hardcoded hex to match each file's existing styling convention. - Widen the Dialect column so "TS-2000" is no longer clipped (applet 68->84, popout 86->100; popout header 88->102 to preserve its header/grid offset). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #3609
Summary
A user reported being unable to access the CAT port. The cause turned out to be discoverability: the CAT control table has a per-port enable checkbox, but it was easy to miss on two fronts — the column header read
En(looks truncated), and the defaultQCheckBoxindicator is nearly invisible against the dark applet/pop-out background. You can have the CAT server on globally yet never tick the individual port's box. The reporter confirmed he hadn't realized he needed to enable the port with the checkbox, and liked the new design.Changes
En→Enabled(widened and centered) in both the floating applet (CatControlApplet.cpp) and the pop-out window (CatPopoutWindow.cpp).QCheckBox::indicatorwith a high-contrast border when unchecked and a filled accent when checked, so on/off reads at a glance. Added an"Enable this CAT port"tooltip. The applet uses theme tokens ({{color.accent}}…); the pop-out uses hardcoded hex to match each file's existing styling convention.TS-2000is no longer clipped (applet 68→84px, pop-out 86→100px; pop-out header 88→102px to preserve its header/grid offset).Screenshot
Files changed
src/gui/CatControlApplet.cppkEnableCheckindicator style, tooltip, Dialect widthsrc/gui/CatPopoutWindow.cppkCheckStyleindicator style, tooltip, column-0 min width, Dialect widthTesting
Built clean on MacBook Air M2; verified visually in the running app (applet + pop-out):
Enabledheader fits, checkboxes clearly show enabled/disabled state in dark mode,TS-2000no longer clipped. The original reporter confirmed the redesigned control made the per-port enable obvious.🤖 Generated with Claude Code