feat(waveform): Docker waveform install via file upload protocol

[NF0T]

Summary

Adds Docker waveform container install to the File → Waveforms dialog, mirroring the SmartSDR Waveform Manager's Install flow.

What's new:

• Install… button in the WFP status bar, enabled only when WFP is powered and ready. Opens a file picker filtered to *.tar.gz / *.tgz, streams the image to the radio, and shows a cancelable progress dialog.
• WaveformInstaller (src/core/) — new class implementing the file upload <size> waveform_docker_image <filename> protocol confirmed by pcap (fw 4.2.18). Validates the archive before loading (gzip magic 0x1F 0x8B or POSIX tar ustar magic at byte 257; accepts both because newer FlexRadio releases ship uncompressed OCI-layout tars despite the .tar.gz extension). 500 MB ceiling, 64 KB chunk streaming, 10 s connect timeout with fallback to port 42607. Mirrors FirmwareUploader in structure.
• WaveformsDialog now takes RadioModel* (was FlexWaveformModel*) to give it access to the installer's dependencies. Existing Remove/Restart per-row buttons are unchanged. Status indicator colors and list badges now resolve from theme tokens (color.accent, color.text.secondary) and reconnect on themeChanged.
• lcWaveform (aether.waveform) logging category added to LogManager.

The waveform list updates automatically after install via the existing FlexWaveformModel::handleContainerStatus / waveformsChanged signal — no extra wiring required.

Legacy waveform install (non-Docker) is deferred.

Constitution principle honored

Principle VIII — Evidence Over Assertion. The install protocol — file upload <size> waveform_docker_image <filename>, dynamic TCP port, ustar/gzip dual-format validation — is derived entirely from pcap 4.2.18-waveform-install.pcapng, not from documentation or assumptions. The plain-tar format discovery (OCI layout, no gzip) was confirmed by inspecting the actual bytes of freedv-waveform-2.4.0-dev-7132.tar.gz before widening the validator.

Principle XI — Fixes Are Demonstrated. Install of a fresh container, remove, and reinstall of the same container verified OTA on a FLEX-8400 (NF0T).

Test plan

• Local build passes (MinGW GCC 13 / Qt 6.11.0, cmake --build /c/AetherBuild)
• Docker waveform install verified on real radio — FLEX-8400, NF0T: fresh install of newer version, remove container, reinstall same version, all confirmed working
• Install button correctly disabled before WFP ready; enables on wfp_status power=on ready=true
• Cancel during upload aborts the TCP transfer and re-enables the button
• Gzip magic check rejects non-archive files; ustar check accepts OCI-layout tars
• CI (pending)

Checklist

• Commits signed (docs/COMMIT-SIGNING.md)
• No new flat-key AppSettings calls — waveform state is radio-authoritative; no client-side persistence added
• No meter UI added — MeterSmoother not applicable
• WaveformsDialog theming: status indicators, list badges, and progress dialog resolve via ThemeManager tokens; themeChanged wired for live re-paint

[aethersdr-agent]

Thanks for this, @NF0T — the pcap-derived protocol notes are excellent, the WaveformInstaller is a clean line-for-line mirror of the shipping FirmwareUploader, the dual gzip/ustar validation is well-justified, and the theme-token migration (color.accent / color.text.secondary, applyStyleSheet, themeChanged re-wire) is exactly right. All APIs check out (RadioModel::sendCmdPublic, radioAddress(), flexWaveformModel()), no client-side persistence added, and CI is green across all 6 checks. The on-radio verification (install/remove/reinstall on a FLEX-8400) is great evidence.

One real bug and one minor defensive note:

1. (Likely crash on 2nd install) finished connections accumulate on the reused installer → use-after-free of the stale progress dialog.

In onInstallClicked() the installer is created once and reused (if (!m_installer) m_installer = new WaveformInstaller(...)), but each click adds a new finished connection whose context is this (the dialog), capturing that click's progress by value:

connect(m_installer, &WaveformInstaller::finished,
        this, [this, progress](bool ok, const QString& msg) {
            progress->close();
            progress->deleteLater();
            ...
        });

The progressChanged→progress and canceled→m_installer connections auto-disconnect when progress dies (it's the sender/context there), but this finished connection does not — its context is the long-lived dialog. So on the second install, the first install's lambda is still connected and fires with a dangling progress (already deleteLater()'d after install #1), calling progress->close() on freed memory.

Suggested fixes (any one):

• Make the connection single-shot: connect(m_installer, &WaveformInstaller::finished, this, [...]{...}, Qt::SingleShotConnection);
• Or create a fresh WaveformInstaller per install and deleteLater() it in the finished handler, instead of caching m_installer.
• Or use progress as the connection's context object (it outlives nothing here, and this is captured anyway).

2. (Minor, inherited) Guard onError()/onBytesWritten() against post-completion re-emission.

After a successful upload, onBytesWritten() calls disconnectFromHost() and emits finished(true), but the socket signals stay connected. If the radio closes the connection around the same time, errorOccurred can fire onError(), which (since m_bytesSent > 0) falls through to emit finished(false, ...) — surfacing a spurious "Install Failed" box right after "Install Complete". This pattern is inherited verbatim from FirmwareUploader, but there the radio reboots so the dialog context disappears; here the radio stays up, so it's more likely to surface. A cheap guard — if (!m_installing) return; at the top of onError() (and onBytesWritten()) — closes it. Your hardware test didn't hit it, so this is precautionary, not a blocker.

Nice work overall — fix #1 before merge and this is in good shape.

---

_{🤖 aethersdr-agent · cost: $3.5072 · model: claude-opus-4-8}

[NF0T]

Thanks for the thorough review — both issues addressed in the amended commit (ac237c2a):

#1 (SingleShotConnection): Added Qt::SingleShotConnection to the finished→dialog lambda in WaveformsDialog::onInstallClicked(). The lambda now auto-disconnects after firing, so a reused m_installer can't invoke a stale progress pointer on a subsequent install.

#2 (post-completion guard): Added !m_installing to the early-return guards in WaveformInstaller::onError() and onBytesWritten() (alongside the existing m_cancelled check). Any socket signal arriving after a completed upload is now silently dropped before it can emit a second finished().