Skip to content

Fix ExcelSheet #1853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wolfcomp merged 2 commits into from
Jun 3, 2026
Merged

Fix ExcelSheet #1853

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e391da5
Fix ExcelSheet
Haselnussbomber Jun 3, 2026
538b62f
Add a quick note for function
wolfcomp Jun 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion FFXIVClientStructs/FFXIV/Common/Component/Excel/ExcelSheet.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,14 @@ public unsafe partial struct ExcelSheet {
[MemberFunction("E8 ?? ?? ?? ?? 8B D0 BD")]
public partial uint GetAllocatedRowCount();

[MemberFunction("48 89 5C 24 ?? 48 89 6C 24 ?? 48 89 74 24 ?? 57 48 83 EC ?? 48 8B F9 48 8D 74 24")]
public partial IExcelRowWrapper* GetRowByDescriptor(ExcelRowDescriptor* descriptor, uint* outErrorCode = null); // No xref possibly inlined somewhere

[MemberFunction("E8 ?? ?? ?? ?? 48 8B 4F ?? 49 89 44 0E")]
public partial IExcelRowWrapper* GetRowByDescriptor(ExcelRowDescriptor* descriptor, uint* outErrorCode = null);
public partial IExcelRowWrapper* GetSubRowByDescriptor(ExcelRowDescriptor* descriptor, uint* outErrorCode = null);

[MemberFunction("E8 ?? ?? ?? ?? 48 85 C0 74 ?? B0 ?? EB")]
public partial IExcelRowWrapper* GetRowByIndex(uint rowIndex, ExcelRowDescriptor* descriptor);

[MemberFunction("E8 ?? ?? ?? ?? 8B D3 48 8B F8")]
public partial IExcelRowWrapper* GetRowById(uint rowId, uint* outErrorCode = null);
Expand Down
3 changes: 2 additions & 1 deletion ida/data.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4776,7 +4776,8 @@ classes:
0x14207D4D0: GetSubRowByDescriptor
0x14207D610: GetRowById
0x14207D750: GetColumnStringByDescriptor
0x14207D960: GetRowByDescriptor
0x14207D960: GetRowByIndex
0x14207D9D0: GetRowByDescriptor
0x14207DB00: GetSheetName
0x14207DB10: GetColumnOffset
0x14207DBC0: GetColumnIndex2
Expand Down
Loading