Conversation
Previously, Tab in the remote address bar only completed from cached suggestions (remoteEntries). If the cache was stale or empty, Tab did nothing — unlike the local pane which always fetches fresh from /api/browse. Added an optional onTabComplete callback to PathBar/FilePane. When Tab is pressed with no suggestions, it fires onTabComplete(inputValue). The remote pane wires this to handleRemoteNavigateTo, sending a BrowseRequest over WS so local and remote share the same Tab completion behavior.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThis PR threads an optional ChangesTab-completion callback threading
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Code Review
This pull request introduces an onTabComplete callback prop across the App, FilePane, and PathBar components to handle tab completion when no suggestions are available. The review feedback points out a redundant type intersection in the PathBar component signature, as onTabComplete is already defined in PathBarProps.
Previously, Tab in the remote address bar only completed from cached suggestions (remoteEntries). If the cache was stale or empty, Tab did nothing — unlike the local pane which always fetches fresh from /api/browse.
Added an optional onTabComplete callback to PathBar/FilePane. When Tab is pressed with no suggestions, it fires onTabComplete(inputValue). The remote pane wires this to handleRemoteNavigateTo, sending a BrowseRequest over WS so local and remote share the same Tab completion behavior.
Summary by CodeRabbit