Skip to content

Conversation

@juliannguyen4
Copy link
Collaborator

@juliannguyen4 juliannguyen4 commented Dec 18, 2025

TODO

  • Add Dominic as co-author
  • Memory leak from ctx...

Extra changes

  • This approach creates a separate helper function to retrieve and convert a Python list of contexts from a dictionary. All list and map operations that take in a ctx will use this new helper function
  • The original helper function now only accepts a Python list of contexts. This is to be used for client.index_cdt_create() and Query.where()

Manual testing

  • massif usage looks ok
  • build artifacts tests passes

@codecov-commenter
Copy link

codecov-commenter commented Dec 18, 2025

Codecov Report

❌ Patch coverage is 94.30052% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.38%. Comparing base (e81f62d) to head (c9f60f8).
⚠️ Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
src/main/conversions.c 80.64% 6 Missing ⚠️
src/main/client/cdt_list_operate.c 98.44% 2 Missing ⚠️
src/main/client/get_cdtctx_base64.c 75.00% 2 Missing ⚠️
src/main/query/where.c 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #903      +/-   ##
==========================================
+ Coverage   83.34%   83.38%   +0.04%     
==========================================
  Files          99       99              
  Lines       14425    14379      -46     
==========================================
- Hits        12022    11990      -32     
+ Misses       2403     2389      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…g-empty-list-or-none-to-ctx-param-failing-LONG-TERM
@juliannguyen4 juliannguyen4 changed the title [CLIENT-3651] Fix passing empty list or none to ctx param failing (long term fix) [CLIENT-3651] Fix passing empty list or none to ctx param failing for Query.where(), client.index_cdt_create(), and all operations that have a ctx parameter Jan 2, 2026
@juliannguyen4 juliannguyen4 changed the title [CLIENT-3651] Fix passing empty list or none to ctx param failing for Query.where(), client.index_cdt_create(), and all operations that have a ctx parameter [CLIENT-3651] Refactor Query.where() and client.index_cdt_create() code that converts the ctx parameter Jan 28, 2026
@juliannguyen4 juliannguyen4 changed the title [CLIENT-3651] Refactor Query.where() and client.index_cdt_create() code that converts the ctx parameter [CLIENT-3651] Refactor ctx conversion code Jan 28, 2026
@juliannguyen4 juliannguyen4 changed the title [CLIENT-3651] Refactor ctx conversion code [CLIENT-3651] Refactor aerospike_helpers.cdt_ctx conversion code Jan 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants