-
Notifications
You must be signed in to change notification settings - Fork 112
[CLIENT-3651] Refactor aerospike_helpers.cdt_ctx conversion code #903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
juliannguyen4
wants to merge
63
commits into
dev
Choose a base branch
from
CLIENT-3651-fix-passing-empty-list-or-none-to-ctx-param-failing-LONG-TERM
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[CLIENT-3651] Refactor aerospike_helpers.cdt_ctx conversion code #903
juliannguyen4
wants to merge
63
commits into
dev
from
CLIENT-3651-fix-passing-empty-list-or-none-to-ctx-param-failing-LONG-TERM
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g-empty-list-or-none-to-ctx-param-failing-LONG-TERM
…g-empty-list-or-none-to-ctx-param-failing-LONG-TERM
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #903 +/- ##
==========================================
+ Coverage 83.34% 83.38% +0.04%
==========================================
Files 99 99
Lines 14425 14379 -46
==========================================
- Hits 12022 11990 -32
+ Misses 2403 2389 -14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…g-empty-list-or-none-to-ctx-param-failing-LONG-TERM
ctx param failing (long term fix)ctx param failing for Query.where(), client.index_cdt_create(), and all operations that have a ctx parameter
…g-empty-list-or-none-to-ctx-param-failing-LONG-TERM
…y called fixed that contain a ctx list
…akes in an optional ctx parameter, but adding a is_cdt_ctx_optional param to this helper makes the helpers consistent
…g-empty-list-or-none-to-ctx-param-failing-LONG-TERM
ctx param failing for Query.where(), client.index_cdt_create(), and all operations that have a ctx parameter…ed as_cdt_ctx obj
…g-empty-list-or-none-to-ctx-param-failing-LONG-TERM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
Extra changes
Manual testing