Open
Conversation
mcoberly2
reviewed
Jan 19, 2024
Collaborator
mcoberly2
left a comment
mcoberly2
left a comment
There was a problem hiding this comment.
I am puzzled Trino 4.5.0-431 has not been released.
If I approve this will it be merged prematurely?
Collaborator
Author
|
@mcoberly2 I was thinking we will trigger the merge of the branch only after the release. In the meantime, reviewers can approve it. Does it sound OK? |
rahul-aerospike
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed notebooks since they do not use our binaries.
Changed the descriptionFixed call topresto.connect()Api to work with Trino server 435Added some headers etc to beautifyUpdated the link to trino examples page@mcoberly2 @reugn @artanderson