Fix CLI --mode animator not exporting AnimationClip with --fbx-animation all, and add support for --fbx-uvs-as-diffuse, add FBX ASCII format support for CLI#124
Open
haojiezhe12345 wants to merge 3 commits intoaelurum:AssetStudioModfrom
Conversation
--mode animator --fbx-animation all not exporting AnimationClips--mode animator not exporting AnimationClip with --fbx-animation all, and add support for --fbx-uvs-as-diffuse
--mode animator not exporting AnimationClip with --fbx-animation all, and add support for --fbx-uvs-as-diffuse--mode animator not exporting AnimationClip with --fbx-animation all, and add support for --fbx-uvs-as-diffuse, add FBX ASCII format support for CLI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Fix
--fbx-animation allnot working with--mode animatorwith CLI option
--mode animator --fbx-animation allit should export Animator + AnimationClips, but it fails to add AnimationClips because the type is not added to theo_exportAssetTypeslistas seen in
ExportAnimator(), Studio.cs:961, it has anexportAllAnimationsflag which adds AnimationClips toanimationList, but because all AnimationClips is filtered out, nothing will be addedas observed,
parsedAssetsListis added byParseAssets(), and the exportable filtering logic is located at Studio.cs:332by adding
ClassIDType.AnimationCliptoo_exportAssetTypesinWorkMode.Animator, AnimationClips are kept and animations will be exported in the modelit is sure that
AnimationExportMode.All(--fbx-animation all) is designed to use here because this is the only reference to it2. Fix the 'unsupported' message for
--fbx-uvs-as-diffusein--mode animator--fbx-uvs-as-diffuseis designed to work with FBX export whereWorkMode.SplitObjectsdoes, butWorkMode.Animatoralso does this job. Both these two modes should accept this flag3. Added CLI option
--fbx-ascii-formatWith this switch, FBX will be exported in ASCII format, otherwise in Binary.