Add strip path prefix while grouping by container, and add filter exclude mode by MejiroRina · Pull Request #113 · aelurum/AssetStudio

MejiroRina · 2025-11-10T12:05:02Z

No description provided.

- Added --filter-blacklist-mode flag

- Added --strip-path-prefix flag

sounds better

Copilot

Pull request overview

This PR adds two new features to AssetStudioCLI: a filter exclude mode that inverts filter logic to exclude matching assets rather than include them, and a strip path prefix option for cleaner export paths when grouping assets by container path.

Changes:

Added --filter-exclude-mode flag to invert filter behavior, excluding assets that match filter criteria instead of including them
Added --strip-path-prefix option to remove a specified prefix from container paths during export when using ContainerPath/ContainerPathFull grouping
Updated documentation in ReadMe.md and option descriptions in CLIOptions.cs

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 10 comments.

File	Description
AssetStudioCLI/Studio.cs	Implements filter exclusion logic and path prefix stripping with validation
AssetStudioCLI/Options/CLIOptions.cs	Adds new option declarations, initialization, parsing, and display logic for both features
AssetStudioCLI/ReadMe.md	Documents the new `--filter-exclude-mode` and `--strip-path-prefix` options

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

AssetStudioCLI/Studio.cs

Copilot · 2026-01-23T17:59:17Z

AssetStudioCLI/Studio.cs

            var toExportAssetDict = new ConcurrentDictionary<AssetItem, string>();
            var toParallelExportAssetDict = new ConcurrentDictionary<AssetItem, string>();
+
+            if (CLIOptions.o_stripPathPrefix.Value != null)


The null check pattern here is inconsistent with the rest of the codebase. The default value for o_stripPathPrefix is an empty string (line 540 in CLIOptions.cs), so this will never be null unless explicitly set. Throughout the codebase, string options are checked with equality to empty string (e.g., o_assemblyPath.Value == "" at line 1280). Consider using !string.IsNullOrEmpty(CLIOptions.o_stripPathPrefix.Value) for consistency, or change the default value to null if that's the intended pattern.

Copilot · 2026-01-23T17:59:17Z

AssetStudioCLI/Studio.cs

                        {
-                            exportPath = Path.Combine(savePath, Path.GetDirectoryName(asset.Container));
+                            var containerPath = Path.GetDirectoryName(asset.Container);
+                            if (CLIOptions.o_stripPathPrefix.Value != null)


Same null check pattern issue as lines 663 and 682. This should use !string.IsNullOrEmpty() for consistency with the rest of the codebase.

Copilot · 2026-01-23T17:59:18Z

AssetStudioCLI/Studio.cs

+                    {
+                        continue;
+                    }
+                    if (!Path.Combine(Path.GetDirectoryName(containerPath), Path.GetFileName(containerPath)).StartsWith(CLIOptions.o_stripPathPrefix.Value))


The validation logic using Path.Combine(Path.GetDirectoryName(containerPath), Path.GetFileName(containerPath)) is redundant and potentially problematic. This operation reconstructs the original path but may not handle edge cases correctly (e.g., paths with trailing slashes, root paths, or paths that are just filenames without directories). Consider using containerPath directly for the StartsWith check, as it's simpler and more reliable.

Suggested change

if (!Path.Combine(Path.GetDirectoryName(containerPath), Path.GetFileName(containerPath)).StartsWith(CLIOptions.o_stripPathPrefix.Value))

if (!containerPath.StartsWith(CLIOptions.o_stripPathPrefix.Value))

Copilot · 2026-01-23T17:59:18Z

AssetStudioCLI/Studio.cs

+                var excludeCount = assetsCount - filteredAssets.Count;
+                Logger.Info($"Excluding {excludeCount} asset(s) from export.");


The exclude count calculation is incorrect. The variable excludeCount is calculated as assetsCount - filteredAssets.Count, which represents the number of assets that DON'T match the filter (i.e., assets that will remain). However, when f_filterExcludeMode is enabled, filteredAssets gets inverted to exclude matching assets, so the actual number excluded is filteredAssets.Count (before the inversion). The message should say "Excluding {filteredAssets.Count} asset(s) that match the filter" to accurately reflect what's being excluded.

Suggested change

var excludeCount = assetsCount - filteredAssets.Count;

Logger.Info($"Excluding {excludeCount} asset(s) from export.");

var excludeCount = filteredAssets.Count;

Logger.Info($"Excluding {excludeCount} asset(s) that match the filter.");

Copilot · 2026-01-23T17:59:18Z

AssetStudioCLI/Studio.cs

                        {
-                            exportPath = Path.Combine(savePath, Path.GetDirectoryName(asset.Container));
+                            var containerPath = Path.GetDirectoryName(asset.Container);
+                            if (CLIOptions.o_stripPathPrefix.Value != null)


This Substring operation could throw an ArgumentOutOfRangeException if containerPath is shorter than the prefix length. While the validation loop above attempts to prevent this, it uses a different logic (Path.Combine with GetDirectoryName/GetFileName) that may not guarantee the same result. Add a length check here: if (containerPath.Length >= CLIOptions.o_stripPathPrefix.Value.Length) before calling Substring, or ensure the validation logic matches exactly.

Suggested change

if (CLIOptions.o_stripPathPrefix.Value != null)

if (CLIOptions.o_stripPathPrefix.Value != null &&

!string.IsNullOrEmpty(containerPath) &&

containerPath.Length >= CLIOptions.o_stripPathPrefix.Value.Length)

Copilot · 2026-01-23T17:59:18Z

AssetStudioCLI/Studio.cs

+                }
+            }
+
+            if (CLIOptions.o_stripPathPrefix.Value != null)


Same null check pattern issue as line 663. This should use !string.IsNullOrEmpty() for consistency with the rest of the codebase, or the default value should be changed to null.

Copilot · 2026-01-23T17:59:19Z

AssetStudioCLI/Options/CLIOptions.cs

+            (
+                optionDefaultValue: false,
+                optionName: "--filter-exclude-mode",
+                optionDescription: "(Flag) If specified, the filter options will work as a exclude\n" +


The description says "work as a exclude" which should be "work as an exclusion" (article "an" before vowel sound). This wording inconsistency also exists in the ReadMe.md where it correctly says "work as a exclusion" but should be "work as an exclusion".

Suggested change

optionDescription: "(Flag) If specified, the filter options will work as a exclude\n" +

optionDescription: "(Flag) If specified, the filter options will work as an exclusion\n" +

Copilot · 2026-01-23T17:59:19Z

AssetStudioCLI/ReadMe.md

  --filter-with-regex           (Flag) If specified, the filter options will handle the specified text
                                as a regular expression (doesn't apply to --filter-by-pathid)

+  --filter-exclude-mode       (Flag) If specified, the filter options will work as a exclusion


The description says "work as a exclusion" which should be "work as an exclusion" (article "an" before vowel sound).

Suggested change

--filter-exclude-mode (Flag) If specified, the filter options will work as a exclusion

--filter-exclude-mode (Flag) If specified, the filter options will work as an exclusion

Copilot · 2026-01-23T17:59:19Z

AssetStudioCLI/Options/CLIOptions.cs

                            }
                            break;
+                        case "--strip-path-prefix":
+                            o_stripPathPrefix.Value = Path.Combine(Path.GetDirectoryName(value), Path.GetFileName(value));


Using Path.Combine(Path.GetDirectoryName(value), Path.GetFileName(value)) to normalize the path is problematic. This approach may fail for edge cases: (1) If value is a root path like "C:", GetDirectoryName returns null; (2) If value has a trailing separator, it will be removed; (3) If value is just a filename with no directory, GetDirectoryName returns empty string and Combine will just return the filename. Consider using Path.GetFullPath(value) for proper path normalization, or simply use the value as-is and let the validation in Studio.cs handle the format checking.

Suggested change

o_stripPathPrefix.Value = Path.Combine(Path.GetDirectoryName(value), Path.GetFileName(value));

o_stripPathPrefix.Value = Path.GetFullPath(value);

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

middlered and others added 5 commits November 9, 2025 19:38

[CLI] Add flag to allow filtering assets in blacklist mode.

aa57688

- Added --filter-blacklist-mode flag

[CLI] Add flag to allow removing container path prefix.

de96752

- Added --strip-path-prefix flag

Rename blacklist to exclude

5bd31db

sounds better

[CLI] Inform user when exclude flag is on

d41c9cd

Fix logger info

0a763c5

Copilot AI review requested due to automatic review settings January 23, 2026 17:55

middlered force-pushed the AssetStudioMod branch from 2443e0a to 0a763c5 Compare January 23, 2026 17:55

Copilot started reviewing on behalf of middlered January 23, 2026 17:55 View session

Copilot AI reviewed Jan 23, 2026

View reviewed changes

Remove an empty line

3d5fb9d

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

middlered force-pushed the AssetStudioMod branch from 48bd5bd to 3d5fb9d Compare January 24, 2026 06:44

Copilot is teaching me English grammar

1ac2276

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

Add strip path prefix while grouping by container, and add filter exclude mode#113

Add strip path prefix while grouping by container, and add filter exclude mode#113
MejiroRina wants to merge 7 commits intoaelurum:AssetStudioModfrom
Team-Haruki:AssetStudioMod

MejiroRina commented Nov 10, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI Jan 23, 2026

Uh oh!

Copilot AI Jan 23, 2026

Uh oh!

Copilot AI Jan 23, 2026

Uh oh!

Copilot AI Jan 23, 2026

Uh oh!

Copilot AI Jan 23, 2026

Uh oh!

Copilot AI Jan 23, 2026

Uh oh!

Copilot AI Jan 23, 2026

Uh oh!

Copilot AI Jan 23, 2026

Uh oh!

Copilot AI Jan 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	if (!Path.Combine(Path.GetDirectoryName(containerPath), Path.GetFileName(containerPath)).StartsWith(CLIOptions.o_stripPathPrefix.Value))
	if (!containerPath.StartsWith(CLIOptions.o_stripPathPrefix.Value))

		var excludeCount = assetsCount - filteredAssets.Count;
		Logger.Info($"Excluding {excludeCount} asset(s) from export.");

-                            if (CLIOptions.o_stripPathPrefix.Value != null)
+                            if (CLIOptions.o_stripPathPrefix.Value != null &&
+                                !string.IsNullOrEmpty(containerPath) &&
+                                containerPath.Length >= CLIOptions.o_stripPathPrefix.Value.Length)

	optionDescription: "(Flag) If specified, the filter options will work as a exclude\n" +
	optionDescription: "(Flag) If specified, the filter options will work as an exclusion\n" +

	--filter-exclude-mode (Flag) If specified, the filter options will work as a exclusion
	--filter-exclude-mode (Flag) If specified, the filter options will work as an exclusion

	o_stripPathPrefix.Value = Path.Combine(Path.GetDirectoryName(value), Path.GetFileName(value));
	o_stripPathPrefix.Value = Path.GetFullPath(value);

Comments

Conversation

MejiroRina commented Nov 10, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Copilot AI Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants