Skip to content

Issue/1780#1793

Merged
MaryamMehd merged 5 commits intomainfrom
issue/1780
Feb 18, 2026
Merged

Issue/1780#1793
MaryamMehd merged 5 commits intomainfrom
issue/1780

Conversation

@MaryamMehd
Copy link
Copy Markdown
Collaborator

No description provided.

This change implements runtime configuration support following the same
pattern used in SMART-EHR-Launcher.

Changes:
- Updated Dockerfile to remove build-time VITE_* environment variables
- Dockerfile now uses multi-stage build with nginx for production
- Added config.docker.json as an example configuration file
- Updated docker-compose.yaml to use volume mounts for config.json
- Added inAppPopulate option to ConfigFile interface
- Updated config.ts with new property and validation
- Updated public/config.json with new property
- Added comprehensive Kubernetes ConfigMap documentation

Benefits:
- Single Docker image can be deployed across multiple environments
- No rebuilds required when changing configuration
- Kubernetes-native ConfigMap support
- Configuration changes only require pod restart, not image rebuild
Comment thread LOCAL_DEVELOPMENT.md Outdated
Remove extensive Docker and Kubernetes deployment documentation to keep
the PR focused on runtime configuration functionality.

The documentation, while helpful, adds significant scope to the PR and
can be added separately if needed. This commit keeps only the essential
code changes for runtime configuration support.

Removed:
- Docker build and run examples
- Kubernetes ConfigMap examples
- Deployment and Service YAML examples
- Configuration options table
- Benefits section

Total: 125 lines removed from LOCAL_DEVELOPMENT.md
Copy link
Copy Markdown
Collaborator

@leoniedickson leoniedickson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@MaryamMehd MaryamMehd merged commit 317405b into main Feb 18, 2026
12 checks passed
@MaryamMehd MaryamMehd deleted the issue/1780 branch February 18, 2026 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants