remove cache calls to fetch user membership#1274
Merged
Conversation
klmp200
requested changes
Jan 7, 2026
Contributor
klmp200
left a comment
There was a problem hiding this comment.
À part ça moi ça me va de retirer la complexité
8667340 to
9fb1e72
Compare
9fb1e72 to
c5ae81a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
C'est plus simple et plus rapide d'avoir une cached_property qui stocke tous les membres actifs d'un club (donc presque jamais plus d'une trentaine d'éléments) que de faire un appel au cache à chaque fois qu'on veut la Membership d'un utilisateur