Skip to content

Remove hardcoded models as data dependencies in src packs#304

Merged
knewbury01 merged 4 commits intomainfrom
knewbury01/change-dependency-structure-mad
Feb 23, 2026
Merged

Remove hardcoded models as data dependencies in src packs#304
knewbury01 merged 4 commits intomainfrom
knewbury01/change-dependency-structure-mad

Conversation

@knewbury01
Copy link
Contributor

@knewbury01 knewbury01 commented Feb 19, 2026

What This PR Contributes

removes the hardcoded dependency on the source packs to the model packs

additionally fixes the xsjs test pack which was missing a dependency on the model pack (this is required for test packs since there is no other mechanism to link a test run execution with some model packs)

Future Works

@data-douser data-douser self-requested a review February 20, 2026 16:40
@knewbury01 knewbury01 enabled auto-merge February 23, 2026 15:57
Copy link
Collaborator

@data-douser data-douser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Such an elegant fix for such an inelegant problem.

Thank you @knewbury01

LGTM!

@knewbury01 knewbury01 self-assigned this Feb 23, 2026
@knewbury01 knewbury01 merged commit 3e54dfa into main Feb 23, 2026
15 checks passed
@knewbury01 knewbury01 deleted the knewbury01/change-dependency-structure-mad branch February 23, 2026 16:36
@knewbury01 knewbury01 mentioned this pull request Mar 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants