fix(search): correct export citation loading and selection handling#881
Draft
thostetler wants to merge 1 commit into
Draft
fix(search): correct export citation loading and selection handling#881thostetler wants to merge 1 commit into
thostetler wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #881 +/- ##
========================================
+ Coverage 61.2% 61.4% +0.3%
========================================
Files 348 348
Lines 41373 41405 +32
Branches 1826 1839 +13
========================================
+ Hits 25297 25412 +115
+ Misses 16033 15948 -85
- Partials 43 45 +2
🚀 New features to boost your workflow:
|
Search-page citation export had two issues: exporting 'all' showed an empty/placeholder state for several seconds before results appeared, and after exporting a subselection it was impossible to export all records because the previous subset's qid was reused. - Surface a loading state during the initial export fetch in useCitationExporter and consume it in CitationExporter - Render a loading skeleton on the export page until the search data and the client are ready, removing the static-to-interactive hydration swap - Gate the vault qid navigation on selected mode so 'export all' uses the plain query and ignores a stale cached qid; preserve the selection - Add tests for the initial loading state and the selection/qid handling
97711e3 to
3be10e0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Search-page citation export had two issues: exporting all showed an empty/placeholder state for several seconds before results appeared, and after exporting a subselection it was impossible to export all records because the previous subset's qid was reused.