SCIX-678 fix: prevent empty affiliations from displaying with partial… #2362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… authors When documents have partial authors loaded (e.g., 3 out of 2874), clicking "Show affiliations" was displaying empty affiliation entries for authors that hadn't been loaded yet. This change implements proper affiliation slicing and caching to match the loaded author set.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves lazy loading for authors and affiliations on the abstract page to fix issues with empty affiliations being displayed. The changes separate the transform logic into a dedicated function and add proper lazy loading for the authors list.
Key changes:
- Refactored author/affiliation data processing into a separate
updateAuthorAffiliationmethod - Added lazy loading support for partial author data with new
fetchAuthorsmethod - Enhanced template logic to prevent empty affiliations from being displayed
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/js/widgets/abstract/widget.js |
Major refactoring of author/affiliation processing logic with new lazy loading capabilities |
src/js/widgets/abstract/templates/abstract_template.html |
Updated template to conditionally show affiliations and display author count information |
test/mocha/js/widgets/abstract_widget.spec.js |
Added comprehensive tests for the new lazy loading functionality |
src/shared |
Updated subproject commit reference |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| } | ||
|
|
||
| // Explicitly copy full affiliation array before any slicing | ||
| const fullAff = freshDoc.aff ? [...freshDoc.aff] : undefined; |
There was a problem hiding this comment.
Using undefined as the fallback value is inconsistent with the rest of the codebase where empty arrays are used for missing affiliation data. Consider using [] instead for consistency.
Suggested change
| const fullAff = freshDoc.aff ? [...freshDoc.aff] : undefined; | |
| const fullAff = freshDoc.aff ? [...freshDoc.aff] : []; |
shinyichen
approved these changes
Nov 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A larger fix to improve how we do the lazy loading for author and affiliations on the abstract page.
This now moves the transform part into a separate function
Makes the authors list also be properly lazy, and some general clean up along with some more guarding inside the parser