Fix DOI disappearing during fetchAffiliations hydration (SCIX-670) #2360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use this.defaultQueryArguments.fl instead of hardcoded field list - Preserve all document fields during hydration merge - Add test case to verify DOI preservation Fixes SCIX-670
thostetler
force-pushed
the
SCIX-670-bbb-doi-is-disappearing-after-loading-an-abstract
branch
from
41e338f to
1ac5433
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where the DOI field was being lost during the fetchAffiliations hydration process on abstract pages. The root cause was a hardcoded field list that excluded DOI fields when fetching updated affiliation data.
Key Changes:
- Replaced hardcoded field list with
this.defaultQueryArguments.flto include all necessary fields - Simplified the merge logic to use the complete API response instead of cherry-picking fields
- Added a comprehensive test case to verify DOI preservation during hydration
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/js/widgets/abstract/widget.js | Updated fetchAffiliations to use full default field list and complete document in merge logic |
| test/mocha/js/widgets/abstract_widget.spec.js | Added test case verifying DOI preservation during affiliation fetching |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
shinyichen
approved these changes
Oct 29, 2025
thostetler
deleted the
SCIX-670-bbb-doi-is-disappearing-after-loading-an-abstract
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The DOI was disappearing on abstract pages during hydration because the
fetchAffiliationsmethod was using a hardcoded field list (fl) that only included author/affiliation fields but excluded DOI fields.Solution
this.defaultQueryArguments.flto ensure all necessary fields (including DOI) are preservedfreshDocinstead of manually selecting specific fieldsFixes SCIX-670