Open
Conversation
AlexStefan17
requested review from
AdrianCiuciui,
AndreeaHasel,
PopDan23,
RaduMoldovan30,
adrianmaciuc,
iclaudiu98,
pmirel and
simonleventeattila
| const productDetails = new ProductDetails(page); | ||
|
|
||
| await homePage.navigateToHomePage(); | ||
| const randomNumber = Math.floor(Math.random() * 6); |
Owner
There was a problem hiding this comment.
This should be a method. In a file called utils, under a folder called lib or helpers. Once that is done, just import here and call the method
| .locator(`nth=${randomNumber}`) | ||
| .innerText() | ||
| ).split("\n")[0]; | ||
| await homePage.hotSellersProducts().locator(`nth=${randomNumber}`).click(); |
Owner
There was a problem hiding this comment.
În POM you don't have selectors in test. Moving this into page and try something nice there
Comment on lines
+17
to
+22
| const productName = ( | ||
| await homePage | ||
| .hotSellersProducts() | ||
| .locator(`nth=${randomNumber}`) | ||
| .innerText() | ||
| ).split("\n")[0]; |
Owner
There was a problem hiding this comment.
This should be a method inside of productPage and just referenced here.
Tests don't have logic or selectors.
adrianmaciuc
approved these changes
Feb 11, 2024
| import { HomePage } from "../pages/home.page"; | ||
| /** | ||
| * Navigates to the home page and generates a random number between 0 and max (exclusive). | ||
| * @param {Object} homePage - The object representing the home page. |
Owner
There was a problem hiding this comment.
Annotations says you take two params, but function takes only one
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rework hotSellectorSecion with POM