Verify if 4 products are under Hot sellers category#97
Open
iclaudiu98 wants to merge 1 commit intomainfrom
Open
Verify if 4 products are under Hot sellers category#97iclaudiu98 wants to merge 1 commit intomainfrom
iclaudiu98 wants to merge 1 commit intomainfrom
Conversation
-test created
iclaudiu98
requested review from
AdrianCiuciui,
AlexStefan17,
AnduTutoveanu09,
Iulian99,
PopDan23,
RaduMoldovan30,
adrianmaciuc and
pmirel
| page, | ||
| }) => { | ||
| await page.goto("https://magento.softwaretestingboard.com/gear.html"); | ||
| const products = await page.locator(".product-image-photo").count(); |
Collaborator
There was a problem hiding this comment.
It is recommended to utilize Playwright's built-in methods for assertions
const products = await page.locator(".product-image-photo");
await expect(products).toHaveCount(4);
Owner
There was a problem hiding this comment.
Perfect. Now how would you write this in just one line?
Comment on lines
+7
to
+8
| const products = await page.locator(".product-image-photo").count(); | ||
| await expect(products).toBe(4); |
Owner
There was a problem hiding this comment.
Suggested change
| const products = await page.locator(".product-image-photo").count(); | |
| await expect(products).toBe(4); | |
| await expect(page.locator(".product-image-photo")).toHaveCount(4); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test created for #78
.product-image-photo locator used to identify hotseller products, it is unique for every hotseller product.