Add SafeString As A Valid Message Type#387
Closed
ardeliatay wants to merge 4 commits intoadopted-ember-addons:masterfrom
Closed
Add SafeString As A Valid Message Type#387ardeliatay wants to merge 4 commits intoadopted-ember-addons:masterfrom
ardeliatay wants to merge 4 commits intoadopted-ember-addons:masterfrom
Conversation
Contributor
|
@ardeliatay well, it's been a couple of years already but do you want to wrap up your pr by any chance? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
Argument of type SafeString' is not assignable to parameter of type 'string'TS error when passing aSafeStringto the flash message service methods:This ticket added
SafeStringas a valid argument to the flash message methods, but currently the type for message is only a string. This PR introduces aMessagetype for message arguments to includeSafeStringto align with that behaviour.