Skip to content

Add SafeString As A Valid Message Type#387

Closed
ardeliatay wants to merge 4 commits intoadopted-ember-addons:masterfrom
ardeliatay:fix-message-type
Closed

Add SafeString As A Valid Message Type#387
ardeliatay wants to merge 4 commits intoadopted-ember-addons:masterfrom
ardeliatay:fix-message-type

Conversation

@ardeliatay
Copy link
Copy Markdown

@ardeliatay ardeliatay commented Aug 25, 2022

Fix Argument of type SafeString' is not assignable to parameter of type 'string' TS error when passing a SafeString to the flash message service methods:

this.flashMessages.success(htmlSafe('Success!'));
// Argument of type SafeString' is not assignable to parameter of type 'string'

This ticket added SafeString as a valid argument to the flash message methods, but currently the type for message is only a string. This PR introduces a Message type for message arguments to include SafeString to align with that behaviour.

@ardeliatay ardeliatay changed the title Fix message type Add SafeString As A Valid Message Type Aug 25, 2022
@ardeliatay ardeliatay marked this pull request as ready for review August 26, 2022 17:45
@stukalin
Copy link
Copy Markdown
Contributor

stukalin commented May 1, 2025

@ardeliatay well, it's been a couple of years already but do you want to wrap up your pr by any chance?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants