Skip to content

chore: use "mail" wording instead of "notification" #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Julien-R44 wants to merge 1 commit into
base: 10.x
Choose a base branch
from
+15 −15
Open

chore: use "mail" wording instead of "notification" #113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion commands/make_mail.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ export default class MakeMail extends BaseCommand {
const codemods = await this.createCodemods()
await codemods.makeUsingStub(stubsRoot, 'make/mail/main.stub', {
flags: this.parsed.flags,
intent: this.intent || 'notification',
intent: this.intent || 'mail',
entity: this.app.generators.createEntity(this.name),
})
}
Expand Down
8 changes: 4 additions & 4 deletions tests/integration/commands/make_mail.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,14 +20,14 @@ test.group('MakeMail', () => {
const command = await ace.create(MakeMail, ['email_verification'])
await command.exec()

command.assertLog('green(DONE:) create app/mails/email_verification_notification.ts')
command.assertLog('green(DONE:) create app/mails/email_verification_mail.ts')
await assert.fileContains(
'app/mails/email_verification_notification.ts',
'app/mails/email_verification_mail.ts',
`import { BaseMail } from '@adonisjs/mail'`
)
await assert.fileContains(
'app/mails/email_verification_notification.ts',
`export default class EmailVerificationNotification extends BaseMail {`
'app/mails/email_verification_mail.ts',
`export default class EmailVerificationMail extends BaseMail {`
)
})

Expand Down
20 changes: 10 additions & 10 deletions tests/unit/fake_mailer/mails.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ test.group('Fake mailer | mails | send', (group) => {
this.message.to('bar@baz.com')
}
}
class PaymentDueNotification extends BaseMail {
class PaymentDueMail extends BaseMail {
from: string = 'foo@bar.com'
subject: string = 'Clear your dues'

Expand All @@ -111,10 +111,10 @@ test.group('Fake mailer | mails | send', (group) => {

await mailer.send(new VerifyEmail())
await mailer.send(new VerifyEmail())
await mailer.send(new PaymentDueNotification())
await mailer.send(new PaymentDueMail())

mails.assertSentCount(VerifyEmail, 2)
mails.assertSentCount(PaymentDueNotification, 1)
mails.assertSentCount(PaymentDueMail, 1)
mails.assertSentCount(3)

assert.throws(() => {
Expand All @@ -138,7 +138,7 @@ test.group('Fake mailer | mails | send', (group) => {
this.message.to('bar@baz.com')
}
}
class PaymentDueNotification extends BaseMail {
class PaymentDueMail extends BaseMail {
from: string = 'foo@bar.com'
subject: string = 'Clear your dues'

Expand All @@ -151,7 +151,7 @@ test.group('Fake mailer | mails | send', (group) => {

await mailer.send(new VerifyEmail())
await mailer.send(new VerifyEmail())
await mailer.send(new PaymentDueNotification())
await mailer.send(new PaymentDueMail())

assert.throws(() => {
return mails.assertNoneSent()
Expand Down Expand Up @@ -310,7 +310,7 @@ test.group('Fake mailer | mails | sendLater', (group) => {
this.message.to('bar@baz.com')
}
}
class PaymentDueNotification extends BaseMail {
class PaymentDueMail extends BaseMail {
from: string = 'foo@bar.com'
subject: string = 'Clear your dues'

Expand All @@ -321,10 +321,10 @@ test.group('Fake mailer | mails | sendLater', (group) => {

await mailer.sendLater(new VerifyEmail())
await mailer.sendLater(new VerifyEmail())
await mailer.sendLater(new PaymentDueNotification())
await mailer.sendLater(new PaymentDueMail())

mails.assertQueuedCount(VerifyEmail, 2)
mails.assertQueuedCount(PaymentDueNotification, 1)
mails.assertQueuedCount(PaymentDueMail, 1)
mails.assertQueuedCount(3)

assert.throws(() => {
Expand All @@ -348,7 +348,7 @@ test.group('Fake mailer | mails | sendLater', (group) => {
this.message.to('bar@baz.com')
}
}
class PaymentDueNotification extends BaseMail {
class PaymentDueMail extends BaseMail {
from: string = 'foo@bar.com'
subject: string = 'Clear your dues'

Expand All @@ -361,7 +361,7 @@ test.group('Fake mailer | mails | sendLater', (group) => {

await mailer.sendLater(new VerifyEmail())
await mailer.sendLater(new VerifyEmail())
await mailer.sendLater(new PaymentDueNotification())
await mailer.sendLater(new PaymentDueMail())

assert.throws(() => {
return mails.assertNoneQueued()
Expand Down
Loading