Skip to content

fix: use caught error variable in reportProgress catch block#75

Closed
davisthedev wants to merge 1 commit into
adonisjs:11.xfrom
davisthedev:bugfix/ReportProgress
Closed

fix: use caught error variable in reportProgress catch block#75
davisthedev wants to merge 1 commit into
adonisjs:11.xfrom
davisthedev:bugfix/ReportProgress

Conversation

@davisthedev

@davisthedev davisthedev commented Jan 23, 2026

Copy link
Copy Markdown

🔗 Linked issue

76

❓ Type of change

  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

The catch block was using error (from validateProcessedBytes) instead of
err (the caught exception), causing undefined to be emitted when
reportProgress throws, which crashes the error handler.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@davisthedev

davisthedev commented Jan 23, 2026

Copy link
Copy Markdown
Author

Apologies for missing any steps for your process. I came across this working on a project and it was causing my api to crash.

@thetutlage

Copy link
Copy Markdown
Member

Is it possible for you to write a test that helps us reproduce this issue? Or maybe share a scenario I could use to test it myself

@thetutlage thetutlage closed this in b456762 Feb 1, 2026
@davisthedev

davisthedev commented Feb 17, 2026

Copy link
Copy Markdown
Author

@thetutlage Can I open a pull request to merge this into 10.x version?

@thetutlage

Copy link
Copy Markdown
Member

Sure, please do that.

@thetutlage thetutlage reopened this Feb 18, 2026
@davisthedev davisthedev closed this by deleting the head repository Feb 19, 2026
@davisthedev

Copy link
Copy Markdown
Author

ok, i opened: #77

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants