Skip to content

Exclude tmp, storage, and build directories from file watcher #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
guoyunhe wants to merge 4 commits into
base: 8.x
Choose a base branch
from
Open

Exclude tmp, storage, and build directories from file watcher #91

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
61ebf9c
Initial plan
Copilot Mar 8, 2026
1c681c6
Exclude tmp and storage folders from file watcher
Copilot Mar 8, 2026
50351fc
Add build directory to always-excluded file watcher patterns
Copilot Mar 8, 2026
fdfc3cc
Merge pull request #1 from guoyunhe/copilot/exclude-tmp-storage-folder
guoyunhe Mar 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/file_system.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import { memoize } from './utils.ts'
import { type InspectedFile, type AssemblerRcFile } from './types/common.ts'

const DEFAULT_INCLUDES = ['**/*']
const ALWAYS_EXCLUDE = ['.git/**', 'coverage/**', '.github/**', '.adonisjs/**']
const ALWAYS_EXCLUDE = ['.git/**', 'coverage/**', '.github/**', '.adonisjs/**', 'tmp/**', 'storage/**', 'build/**']
const DEFAULT_EXCLUDES = ['node_modules/**', 'bower_components/**', 'jspm_packages/**']

/**
Expand Down Expand Up @@ -111,7 +111,7 @@ export class FileSystem {
*
* Following patterns are always ignored
*
* '.git/**', 'coverage/**', '.github/**'
* '.git/**', 'coverage/**', '.github/**', '.adonisjs/**', 'tmp/**', 'storage/**', 'build/**'
*/
get excludes(): string[] {
return this.#excludes
Expand Down
24 changes: 24 additions & 0 deletions tests/file_system.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,30 @@ test.group('File system', () => {
input: '.git',
result: false,
},
{
input: 'tmp',
result: false,
},
{
input: 'tmp/foo',
result: false,
},
{
input: 'storage',
result: false,
},
{
input: 'storage/logs',
result: false,
},
{
input: 'build',
result: false,
},
{
input: 'build/app',
result: false,
},
])
.run(({ assert }, { input, result }) => {
const config = readTsConfig(BASE_PATH)!
Expand Down