Fixing the push to da and save fix in normal collab#186
Open
aishwaryamathuria wants to merge 2 commits into
Open
Fixing the push to da and save fix in normal collab#186aishwaryamathuria wants to merge 2 commits into
aishwaryamathuria wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
saveAnnotationChanges was calling postData to push HTML to DA using asset.daUrl from the annotation service. We need the persistAnnotationChangesToDA to call batchPromote() first to get the final content.da.live URLs to replace data urls and then push to DA
Both operations in normal and collab seo went through the same saveAnnotationChanges which had the postData call, so both were making push-html calls on save. we only need edit calls on save and no push html Push html is only required in push to da.