fix(timing-framework): respect toggleTime when avoidStreamEndFlag is set#151
Closed
qiyundai wants to merge 1 commit into
Closed
fix(timing-framework): respect toggleTime when avoidStreamEndFlag is set#151qiyundai wants to merge 1 commit into
qiyundai wants to merge 1 commit into
Conversation
avoidStreamEndFlag was reusing stream-ended early-advance paths, causing the schedule to skip to the last timed fragment. Only disable MR blocking; natural underrun and liveStreamEnd still apply when streams actually end. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
Commits
|
Collaborator
Author
|
Superseded by #152, which includes this fix plus traditional worker alignment in a single merge to dev. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
?avoidStreamEndFlag=trueso the chrono-box schedule shows the timed fragment for the current period instead of fast-forwarding to the last slot.avoidStreamEndFlagnow only disables Mobile Rider blocking (overrun hold on active streams); it no longer reuses underrun/liveStreamEndearly-advance paths meant for streams that naturally ended.worker-traditional.js(production path via chrono-box) andworker.js; removes erroneousnextScheduleItemmutation in the module worker.Test plan
npx wtr test/unit/features/timing-framework/worker.test.js --node-resolve --port=2000(45 passed)?avoidStreamEndFlag=trueshows current-period fragment?serverTime=<ms>&avoidStreamEndFlag=trueat a known schedule windowtoggleTime(overrun unchanged)Made with Cursor