Skip to content

LintError fix.#145

Open
hnvadobe wants to merge 5 commits into
devfrom
lintfix-repo
Open

LintError fix.#145
hnvadobe wants to merge 5 commits into
devfrom
lintfix-repo

Conversation

@hnvadobe
Copy link
Copy Markdown

@hnvadobe hnvadobe commented May 13, 2026

Describe your specific features or fixes and provide a preview link for the feature being incorporated

Resolves: MWPW-NUMBER

Test URLs:

@aem-code-sync
Copy link
Copy Markdown

aem-code-sync Bot commented May 13, 2026

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync
Copy link
Copy Markdown

aem-code-sync Bot commented May 13, 2026

Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@sharmeebuilds
Copy link
Copy Markdown
Collaborator

1. drawer.css — Critical: display: box breaks line-clamp (lines 137, 151)

display: -webkit-box was changed to display: box to fix a lint warning, but display: box is ignored by all current browsers. This silently breaks the multi-line text truncation on .drawer-item-title and .drawer-item-description in the mobile drawer. Please revert to display: -webkit-box and suppress the lint warning inline instead:

```css
/* stylelint-disable-next-line property-no-vendor-prefix -- required for -webkit-line-clamp */
display: -webkit-box;
```


2. mobile-rider.css — Nit: Update the lint rule instead of rewriting the selector (line 44)

h2#title_container was rewritten as h2[id="title_container"] to bypass a selector-no-id lint rule, but both forms are functionally identical. Rather than using the verbose attribute selector form, disable the selector-no-id rule in stylelint.config.js — since [id="foo"] is already allowed, #foo should be too:

```js
rules: {
'selector-no-id': null,
}
```

@sharmeebuilds
Copy link
Copy Markdown
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants