#2060 Add fieldgroups and examples supporting Paid Media #2063
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 11, 2025
ejsuncy
force-pushed
the
master-2060-support-paid-media-fieldgroups
branch
from
68ecc4b to
61b5721
Compare
ejsuncy
force-pushed
the
master-2060-support-paid-media-fieldgroups
branch
from
bf25923 to
fe7439a
Compare
rayyang15
force-pushed
the
master-2060-support-paid-media-fieldgroups
branch
from
596fa8e to
a63f4c5
Compare
anandphatak
reviewed
Jan 7, 2026
| { | ||
| "xdm:fieldName": "custom_score", | ||
| "xdm:numberValue": { | ||
| "xdm:value": 87.5 |
Collaborator
There was a problem hiding this comment.
Same question as on previous PR; do you need the id field that comes with the https://ns.adobe.com/xdm/data/measure datatype?
| "title": "Website URL", | ||
| "description": "Business website URL" | ||
| }, | ||
| "xdm:address": { |
Collaborator
There was a problem hiding this comment.
Consider using "Postal Address" standard data type https://ns.adobe.com/xdm/common/address
| "type": "object", | ||
| "meta:extensible": true, | ||
| "meta:abstract": true, | ||
| "meta:intendedToExtend": ["https://ns.adobe.com/xdm/data/record"], |
Collaborator
There was a problem hiding this comment.
meta:intendedToExtend must specify class(es) and not a behavior. https://ns.adobe.com/xdm/data/record is a behavior.
Please make this change to the rest of the field groups.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #2060 will involve multiple PRs to keep the review effort manageable.
This stacked PR should not be merged before PR #2061 and should be rebased after that one is merged.
This PR adds the fieldgroups that build upon the datatypes added in #2061. These new fieldgroups capture Paid Media domain heirarchy knowledge across ad networks (meta, linkedIn, google ads, etc) such as:
It also captures performance metrics concepts, which can be reused at the various hierarchy levels mentioned above. For example, clicks/impressions performance metrics might apply at the Asset level, Ad level, Ad Group level, or Campaign level.
This PR also adds a validation script ("npm run validate") to ensure example files actually adhere to their associated schemas, and that schema "$id" references to other remote schemas actually refer to either: