Open
Conversation
|
Build successful! 🎉 |
|
Build successful! 🎉 |
## API Changes
@react-spectrum/s2/@react-spectrum/s2:RangeValue+RangeValue <T> {
+ end: T
+ start: T
+} |
Comment on lines
+2
to
+3
| import { Text } from 'react-aria-components/Text'; | ||
| import { GridListSection, GridListHeader } from 'react-aria-components/GridList'; |
Member
There was a problem hiding this comment.
we should really apply lint to our examples so we don't get things like mixed spaces
| @@ -12,6 +12,8 @@ | |||
| "strict": true, | |||
| "forceConsistentCasingInFileNames": true, | |||
| "noFallthroughCasesInSwitch": true, | |||
| "verbatimModuleSyntax": true, | |||
Member
There was a problem hiding this comment.
out of curiosity, why'd you apply this? i don't disagree with it, just curious
Member
Author
There was a problem hiding this comment.
oh, i didn't indent to commit this (at least the customConditions). I added verbatimModuleSyntax because apparently vite uses it by default so when people copy and paste our examples they get a ton of errors. Sigh - another case of we have to be more strict than everyone else.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds exports for child components into subpaths for their parents. For example
react-aria-components/ComboBoxincludes Input, Button, ListBox, etc. This way you only need one import statement to get everything you need. It also has the side-benefit of improving discoverability of which components are supported within a parent using TS autocomplete.Also updates the documentation examples and starters to use subpath imports. There are several benefits of subpaths, and the only real downside is needing multiple import statements when using multiple components. It's simpler to update the docs to use subpaths by default than attempt to list them all in the API reference. On the flip side it's easy to use the package index if you want.