Skip to content

fix(react-aria-components): pass overlay id to PopoverContext in Dialogue #9807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
albertdugba wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −0
Open

fix(react-aria-components): pass overlay id to PopoverContext in Dialogue #9807

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/react-aria-components/src/Dialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@ export function DialogTrigger(props: DialogTriggerProps): JSX.Element {
[PopoverContext, {
trigger: 'DialogTrigger',
triggerRef: buttonRef,
id: overlayProps.id,
Copy link
Copy Markdown
Member

@devongovett devongovett Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now we are sending the id to both DialogContext and PopoverContext. This is causing the test failures. We could potentially set id to undefined on DialogContext and only send it to PopoverContext, but not sure.

'aria-labelledby': overlayProps['aria-labelledby'],
style: {'--trigger-width': buttonWidth} as React.CSSProperties
}]
Expand Down
4 changes: 4 additions & 0 deletions packages/react-aria-components/test/Popover.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,10 @@ describe('Popover', () => {
expect(dialog).toBeInTheDocument();
expect(dialog.closest('.react-aria-Popover')).toHaveAttribute('data-trigger', 'DialogTrigger');

let popover = dialog.closest('.react-aria-Popover');
expect(button).toHaveAttribute('aria-controls');
expect(popover).toHaveAttribute('id', button.getAttribute('aria-controls'));

await user.click(document.body);

expect(dialog).not.toBeInTheDocument();
Expand Down
Loading