fix(SelectionManager): support full collection for select all functionality#9621
Open
reidbarber wants to merge 2 commits intomainfrom
Open
fix(SelectionManager): support full collection for select all functionality#9621reidbarber wants to merge 2 commits intomainfrom
reidbarber wants to merge 2 commits intomainfrom
Conversation
|
Build successful! 🎉 |
LFDanLu
reviewed
Feb 6, 2026
Member
LFDanLu
left a comment
There was a problem hiding this comment.
This seems to work well for fixed collections, but what do you think about async loaded items or if the wrapped collection has controlled items (i.e. the filtering is handled externally and items constantly changes causing fullCollection to change)? I suppose for that case it would reasonable to expect selected keys to be tracked outside the component itself?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9620
When you had a collection with
'all'selected inside an Autocomplete, then filtered down the collection and toggled an item, the'all'selection internally was only including filtered items' keys, so you'd lose selection for all non-visible items.This adds a
fullCollectionfield so we can still access the unfiltered collection when toggling selection.✅ Pull Request Checklist:
📝 Test Instructions:
Test new story: