Skip to content

wip: wrap renderEmptyState in CollectionRendererContext.Provider in TableView component#9557

Draft
DPandyan wants to merge 5 commits intomainfrom
nested-collection-tableview-bug
Draft

wip: wrap renderEmptyState in CollectionRendererContext.Provider in TableView component#9557
DPandyan wants to merge 5 commits intomainfrom
nested-collection-tableview-bug

Conversation

@DPandyan
Copy link
Collaborator

@DPandyan DPandyan commented Jan 29, 2026

Closes <No issue created yet, can create one if needed>

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

Just open the last story. Remove the extra CollectionRendererContext.Provider wrapping the Tabs to see the original error.

🧢 Your Project:

Quarry

@DPandyan DPandyan marked this pull request as draft January 29, 2026 23:52
@DPandyan DPandyan changed the title bug: Story for displaying bug of nested collections in TableView wip: Story for displaying bug of nested collections in TableView Jan 29, 2026
@rspbot
Copy link

rspbot commented Feb 5, 2026

];
const renderEmptyState = () => (
<Tabs aria-label="Settings">
<CollectionRendererContext.Provider value={DefaultCollectionRenderer}>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll want to delete this line, which should cause the test to fail.
Once that's verified, we'll want to add this line around the renderEmptyState call so that the rendered child doesn't pick up the wrong context

<div className={centeredWrapper}>

@DPandyan DPandyan changed the title wip: Story for displaying bug of nested collections in TableView wip: wrap renderEmptyState in CollectionRendererContext.Provider in TableView component Feb 6, 2026
@rspbot
Copy link

rspbot commented Feb 7, 2026

@rspbot
Copy link

rspbot commented Feb 7, 2026

## API Changes

react-aria-components

/react-aria-components:HeaderProps

-HeaderProps {
-  render?: DOMRenderFunction<keyof React.JSX.IntrinsicElements, undefined>
-}

/react-aria-components:NumberFieldState

 NumberFieldState {
   canDecrement: boolean
   canIncrement: boolean
-  commit: (string) => void
+  commit: () => void
   commitValidation: () => void
   decrement: () => void
   decrementToMin: () => void
   defaultNumberValue: number
   increment: () => void
   incrementToMax: () => void
   inputValue: string
   maxValue?: number
   minValue?: number
   numberValue: number
   realtimeValidation: ValidationResult
   resetValidation: () => void
   setInputValue: (string) => void
   setNumberValue: (number) => void
   updateValidation: (ValidationResult) => void
   validate: (string) => boolean
 }

@react-stately/color

/@react-stately/color:ColorChannelFieldState

 ColorChannelFieldState {
   canDecrement: boolean
   canIncrement: boolean
   colorValue: Color
-  commit: (string) => void
+  commit: () => void
   commitValidation: () => void
   decrement: () => void
   decrementToMin: () => void
   defaultColorValue: Color | null
   displayValidation: ValidationResult
   increment: () => void
   incrementToMax: () => void
   inputValue: string
   maxValue?: number
   minValue?: number
   numberValue: number
   realtimeValidation: ValidationResult
   resetValidation: () => void
   setColorValue: (Color | null) => void
   setInputValue: (string) => void
   setNumberValue: (number) => void
   updateValidation: (ValidationResult) => void
   validate: (string) => boolean
 }

@react-stately/numberfield

/@react-stately/numberfield:NumberFieldState

 NumberFieldState {
   canDecrement: boolean
   canIncrement: boolean
-  commit: (string) => void
+  commit: () => void
   commitValidation: () => void
   decrement: () => void
   decrementToMin: () => void
   defaultNumberValue: number
   increment: () => void
   incrementToMax: () => void
   inputValue: string
   maxValue?: number
   minValue?: number
   numberValue: number
   realtimeValidation: ValidationResult
   resetValidation: () => void
   setInputValue: (string) => void
   setNumberValue: (number) => void
   updateValidation: (ValidationResult) => void
   validate: (string) => boolean
 }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: 🩺 To Triage

Development

Successfully merging this pull request may close these issues.

4 participants