Conversation
snowystinger
left a comment
There was a problem hiding this comment.
Thanks for the PR. We'll need to add a description jsdoc to the function and add it to our documentation as well, would you like to handle that?
You'll also need to sign the CLA
Please sign the Adobe CLA! Once signed, close and re-open your pull request to run the check again.
| toTimeZone, | ||
| toLocalTimeZone, | ||
| fromDate, | ||
| fromDateToLocal, |
There was a problem hiding this comment.
huh... we don't use this function anywhere in our codebase, @devongovett what was the intent here?
There was a problem hiding this comment.
@snowystinger I discovered this function while trying to use fromDate without a timezone. Is there a reason we didn’t just make the timezone optional and keep a single function?
There was a problem hiding this comment.
Seems fine as a shortcut. We should add a JSDoc comment to the function and add to the documentation page though.
Also @maximepvrt you'll need to sign the CLA.
Closes
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: