[WIP] fix: all event targets for shadow dom#9486
Closed
snowystinger wants to merge 6 commits intomainfrom
Closed
Conversation
Base automatically changed from
fix-all-element-contains-for-shadow-dom
to
main
January 23, 2026 01:28
# Conflicts: # eslint.config.mjs # packages/@react-aria/actiongroup/src/useActionGroup.ts # packages/@react-aria/calendar/src/useRangeCalendar.ts # packages/@react-aria/combobox/src/useComboBox.ts # packages/@react-aria/datepicker/src/useDatePickerGroup.ts # packages/@react-aria/dnd/src/DragManager.ts # packages/@react-aria/dnd/src/useDrop.ts # packages/@react-aria/grid/src/useGrid.ts # packages/@react-aria/grid/src/useGridCell.ts # packages/@react-aria/gridlist/src/useGridListItem.ts # packages/@react-aria/interactions/src/useFocusWithin.ts # packages/@react-aria/interactions/src/useHover.ts # packages/@react-aria/interactions/src/useInteractOutside.ts # packages/@react-aria/interactions/src/usePress.ts # packages/@react-aria/landmark/src/useLandmark.ts # packages/@react-aria/menu/src/useSubmenuTrigger.ts # packages/@react-aria/overlays/src/useCloseOnScroll.ts # packages/@react-aria/selection/src/useSelectableCollection.ts # packages/@react-aria/selection/src/useTypeSelect.ts # packages/@react-aria/toolbar/src/useToolbar.ts # packages/@react-aria/utils/src/scrollIntoView.ts # packages/@react-aria/utils/src/shadowdom/DOMFunctions.ts # packages/@react-spectrum/menu/src/useCloseOnScroll.ts # packages/dev/eslint-plugin-rsp-rules/index.js # packages/react-aria-components/src/DropZone.tsx
|
Build successful! 🎉 |
## API Changes
@react-aria/utils/@react-aria/utils:getEventTarget-getEventTarget <T extends Event> {
+getEventTarget <T extends Event | SyntheticEvent> {
event: T
returnVal: undefined
}/@react-aria/utils:nodeContains nodeContains {
- node: Node | null | undefined
- otherNode: Node | null | undefined
+ node: Node | Element | null | undefined
+ otherNode: Node | Element | null | undefined
returnVal: undefined
} |
Member
Author
|
Closing in favour of some extra work i did to minimize TS errors and other lint issues. Also no longer acts on certain events like PressEvents or Drag events if possible, since those are our own objects that don't match actual Events |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes
Another bulk fix for shadow dom, this lints for
event.targetand auto fixes togetEventTarget(event)which just defers toevent.targetunder the hood.Some were done here:
#8991
This PR should make reviewing other ShadowDOM PRs easier and prevent us from regressing
Follow up to #9485
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: