Skip to content

Add rootHiddenOutsideElement #9287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pan-alexey wants to merge 2 commits into
base: main
Choose a base branch
from
+6 −1
Open

Add rootHiddenOutsideElement #9287

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3fc2665
Add rootHiddenOutsideElement
webpan-admin Dec 5, 2025
7dca51a
Lint:fix
webpan-admin Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/@react-aria/overlays/src/usePopover.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,10 @@ export interface AriaPopoverProps extends Omit<AriaPositionProps, 'isOpen' | 'on
* By default, onClose will always be called on interaction outside the popover ref.
*/
shouldCloseOnInteractOutside?: (element: Element) => boolean
/**
* Nothing will be hidden above this element when a popup is modal.
*/
rootHiddenOutsideElement?: Element
}

export interface PopoverAria {
Expand Down Expand Up @@ -89,6 +93,7 @@ export function usePopover(props: AriaPopoverProps, state: OverlayTriggerState):
isNonModal,
isKeyboardDismissDisabled,
shouldCloseOnInteractOutside,
rootHiddenOutsideElement,
...otherProps
} = props;

Expand Down Expand Up @@ -123,7 +128,7 @@ export function usePopover(props: AriaPopoverProps, state: OverlayTriggerState):
if (isNonModal) {
return keepVisible(groupRef?.current ?? popoverRef.current);
} else {
return ariaHideOutside([groupRef?.current ?? popoverRef.current], {shouldUseInert: true});
return ariaHideOutside([groupRef?.current ?? popoverRef.current], {shouldUseInert: true, root: rootHiddenOutsideElement});
}
}
}, [isNonModal, state.isOpen, popoverRef, groupRef]);
Expand Down