Skip to content

fix: (WIP) make sure trackpad taps are not considered as virtual clicks#10225

Draft
LFDanLu wants to merge 2 commits into
mainfrom
10184
Draft

fix: (WIP) make sure trackpad taps are not considered as virtual clicks#10225
LFDanLu wants to merge 2 commits into
mainfrom
10184

Conversation

@LFDanLu

@LFDanLu LFDanLu commented Jun 17, 2026

Copy link
Copy Markdown
Member

Closes #10184

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

Make sure you have tap to click enabled for your track pad. Attempt to tap on checkboxes in FireFox and verify it always toggles the checkbox on tap. Test other browser/device/screenreader combinations.

🧢 Your Project:

RSP

Comment on lines +1228 to +1229
// oxlint-disable-next-line no-unused-vars
using uaMock = jest

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// oxlint-disable-next-line no-unused-vars
using uaMock = jest
using _uaMock = jest

I think this will pass

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unfortunately still caught by the linter :(

@rspbot

rspbot commented Jun 18, 2026

Copy link
Copy Markdown

@snowystinger

Copy link
Copy Markdown
Member

Possibly the Safari bug if we want to chime in https://bugs.webkit.org/show_bug.cgi?id=206216

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

isVirtualPointerEvent false positive for Firefox with trackpad and tap-to-click on macOS

3 participants