Conversation
|
Build successful! 🎉 |
LFDanLu
commented
Jun 12, 2026
nwidynski
reviewed
Jun 12, 2026
|
Build successful! 🎉 |
|
Build successful! 🎉 |
nwidynski
reviewed
Jun 17, 2026
| // if the virtualized item is not visible (aka display none on virtualized collection), | ||
| // we want to avoid reporting size 0 otherwise we get into a state where the virtualizer renders 0 items | ||
| // when it is hidden and thus won't remeasure when it is is unhidden | ||
| if (!isElementVisible(ref.current)) { |
Contributor
There was a problem hiding this comment.
Wondering whether this should maybe be checked on the scrollParent instead. Not sure whether there is a realistic scenario of elements or sections toggling visibility individually though, just a thought.
I guess toggling visibility on an item could/would run into a similar issue with the size being stuck?
It would also be a bit of a pain to get the scrollRef down here, and traversing parents on every render is kind of expensive, so idk.
snowystinger
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10171
✅ Pull Request Checklist:
📝 Test Instructions:
Test the "Virtualized Display None Toggle" gridlist story, the gridlist's items shouldn't disappear even when toggled a bunch
🧢 Your Project:
RSP