Conversation
telegrapher
left a comment
telegrapher
left a comment
There was a problem hiding this comment.
Please have a look at the general organization of the CLI code.
In the cmd package we setup all the parameters, all the cobra concerns. But then, we call the code in the ims package, where we perform all the requests as needed.
For your command, it seems a bit of overkill, but for our more complex tools having everything together was creating problems.
So, please, for consistency, organize your code the same way.
cmd/dcr/register.go
Outdated
|
|
||
| cmd := &cobra.Command{ | ||
| Use: "register", | ||
| Short: "Register a dynamic client.", |
There was a problem hiding this comment.
The client is not dynamic.
You use Dynamic Client Registration to dynamically create clients.
cmd/dcr/register.go
Outdated
| cmd := &cobra.Command{ | ||
| Use: "register", | ||
| Short: "Register a dynamic client.", | ||
| Long: `Register a new OAuth 2.0 client dynamically using OIDC Dynamic Client Registration.`, |
There was a problem hiding this comment.
Don't mention OIDC.
I would not mention "dynamically".
There was a problem hiding this comment.
I would not mention 2.0 either, the server may be using OAuth 2.1 :)
2 participants
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: