Open
Conversation
the list facet used the default sort from distiller, which was using count. in some cases, especially when using lots of `weight=1` requests, this could lead to an order where higher weighted facet elements were shown below lower weighted facet elements, especially when these had a higher count value. this commit changes the default to sort by weight, not by count. in addition, it allows to sort by any metric, so that ranking by lcp or cls would be possible
this is a much less nuanced fix than the other commit, for rum we simply sort by weight, not by count
|
e30ecc1 to
cf5b595
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Preview
https://codex-2--helix-website--adobe.aem.page/developer/ai-coding-agents
Tooling