Split packages/core into packages/core and packages/browser#1411
Open
carterworks wants to merge 66 commits intomainfrom
Open
Split packages/core into packages/core and packages/browser#1411carterworks wants to merge 66 commits intomainfrom
carterworks wants to merge 66 commits intomainfrom
Conversation
Collaborator
Author
|
Serban has identified some issues
|
|
Collaborator
Author
|
Current test failures are related to So we are ready to merge. |
Collaborator
|
Let's merge this after the release. |
# Conflicts: # package.json # packages/browser/test/integration/helpers/mocks/emptyEventResponse.json # packages/browser/test/integration/helpers/mocks/mediaSessionResponse.json # packages/browser/test/integration/helpers/mocks/targetCustomCodeAction.json # packages/browser/test/integration/helpers/mocks/targetPrependHtmlAction.json # packages/browser/test/integration/specs/Advertising/consent_gate.spec.js # packages/core/package.json # packages/core/test/unit/specs/components/Advertising/handlers/viewThroughHandler.spec.js
# Conflicts: # package.json # packages/browser/test/integration/specs/Advertising/clickthrough_duplicate_skwcid.spec.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning
This PR is based off of #1414, which itself is based off of #1412, so this should not be merged until they are.
Description
This PR changes the publishing artifact from being the packages/core folder to a new folder called packages/browser. And that folder gets the @adobe/alloy, and then the core folder appropriately gets the name @adobe/alloy-core. The intent is that both of these packages will be published to NPM.
The core package will be buildless, and then all build steps as well as integration and functional tests, anything to do with a browser stays in the browser package.
No functionality or browser specific functionality has been removed from the packages, the core package, but that is kind of the next step, and hopefully that work can be parallelized.
As it stands right now, the CI test and the publishing workflow still need to be completed. But right now this branch is 95% done.Related Issue
Motivation and Context
Screenshots (if appropriate):
Checklist: