Skip to content

Skyops 84421 snapshots#98

Merged
RemoLiechti merged 76 commits into
mainfrom
SKYOPS-84421_snapshots
Sep 8, 2025
Merged

Skyops 84421 snapshots#98
RemoLiechti merged 76 commits into
mainfrom
SKYOPS-84421_snapshots

Conversation

@RemoLiechti

@RemoLiechti RemoLiechti commented Sep 23, 2024

Copy link
Copy Markdown
Collaborator

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

RemoLiechti and others added 27 commits August 16, 2024 09:38
@RemoLiechti
create skeletons for snapshot commands
0a2f1f8
@RemoLiechti
add support for snapshot requests
6c53d21
@RemoLiechti
skeleton implementation of calling the endpoints, no json ouput yet
170a559
@RemoLiechti
correct aio calls in messages
01b6c87
@RemoLiechti
SKYOPS-84421 adapt to latest spec
b8fc0f1
@RemoLiechti
adapt to snapshots being stored on environment level instead of organ…
a515677 
…izational level
@RemoLiechti
initial snapshot api implemented
e6bb7cf
@RemoLiechti
use snapshot client
d233820
@jsedding
SKYOPS-89194 - [RDE] aio plugin: support setting IMS context via flag
d4e4bca
@angulito
Bump up npm publish workflow version
defe450
@angulito
Merge branch 'main' into SKYOPS-84421_snapshots
d811865 
# Conflicts:
#	src/lib/cloud-sdk-api.js
Add 201 created response code
cd41f51
Tweak arguments
847f5ce
@RemoLiechti
Merge pull request #108 from niekraaijmakers/SKYOPS-84421_snapshots
ff8139d 
Skyops 84421 snapshots
Revert "Tweak arguments"
07f9909 
This reverts commit 847f5ce.
Linting
90c27f5
@RemoLiechti
Merge pull request #109 from niekraaijmakers/SKYOPS-84421_snapshots
ba2eae5 
Revert "Tweak arguments"
Update delete.js
1820344 
Add status code 201
@RemoLiechti
Merge pull request #110 from niekraaijmakers/SKYOPS-84421_snapshots
a3c9d30 
Update delete.js
@RemoLiechti
rename restore to undelete
9d6e118
@RemoLiechti
linting
83144ed
@RemoLiechti
rename keep-deployment to only-mutable-content
15e1fa3
@RemoLiechti
added handling for 503 on delete snapshot
6574720
@RemoLiechti
support node 22.15+
4d09aeb
SKYOPS-84421 reading from metadata files
a77a1b2
SKYOPS-84421 reading from metadata files
5bdced0
@RemoLiechti
Merge pull request #112 from abhishekgarg18/dev-SKYOPS-84421
cd16646 
SKYOPS-84421 reading from metadata files
@sabdouni

sabdouni commented May 21, 2025

Copy link
Copy Markdown

Hello,

Thanks for all the good work on this PR.
Is there an ETA for the release of this feature?
Thanks

@RemoLiechti

RemoLiechti commented May 21, 2025

Copy link
Copy Markdown
Collaborator Author

Hello,

Thanks for all the good work on this PR. Is there an ETA for the release of this feature? Thanks

Hi @sabdouni there is no official GA announced yet. It is still work in progress, but it should be available close future.

Niek Raaijmakers and others added 16 commits July 7, 2025 11:35
More coverage
dbc9197
add coverage of delete.js
de20017
wip - use dev console api for resetting
cd6eb16
Change param name
c00e54e
eslint fixes
2724d17
linting
42d2939
Add unit tests for restore functionality
5feb9c5
Linting fix
f414c18
wip - wrap up test coverage for commands
b4ef73f
Add in the force option
ef4dd7f
Remove the debugging logs
dea1bf7
@RemoLiechti
Merge branch 'SKYOPS-84421_snapshots' into SKYOPS-84421_snapshots
c453943
@RemoLiechti
Merge pull request #113 from niekraaijmakers/SKYOPS-84421_snapshots
bd65201 
Skyops 84421 snapshots - create snapshots command unit test
@RemoLiechti
fix tests
9973f45
@RemoLiechti
Merge pull request #104 from adobe/bump-up-npm-publish-workflow
bdae3ea 
Bump up npm publish workflow version
@RemoLiechti
Merge pull request #100 from adobe/feat/allow-setting-ims-context-via…
2987bea 
…-flag

SKYOPS-89194 - [RDE] aio plugin: support setting IMS context via flag
@RemoLiechti

RemoLiechti commented Jul 29, 2025

Copy link
Copy Markdown
Collaborator Author

hi @sabdouni
seems like you are interested in this work. Please reach out to me(Slack, MS Teams or email) in case you want to test this in the early access program, we might be able to work something out.

@RemoLiechti RemoLiechti marked this pull request as ready for review September 8, 2025 09:07
@RemoLiechti RemoLiechti requested a review from jsedding September 8, 2025 09:07
jsedding
jsedding requested changes Sep 8, 2025
View reviewed changes

@jsedding jsedding left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few small cleanups.

Comment thread src/commands/aem/rde/clean.js Outdated
Comment thread package.json
Comment thread src/commands/aem/rde/clean.js Outdated
@RemoLiechti RemoLiechti requested a review from jsedding September 8, 2025 09:23
@RemoLiechti RemoLiechti merged commit 667ffdc into main Sep 8, 2025
3 checks passed
@RemoLiechti RemoLiechti deleted the SKYOPS-84421_snapshots branch September 8, 2025 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsedding jsedding jsedding approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@RemoLiechti @sabdouni @jsedding @angulito