Skip to content

Simplify dispatcher archive directory#55

Draft
angulito wants to merge 1 commit into
mainfrom
simplify-dispatcher-archive-logic
Draft

Simplify dispatcher archive directory#55
angulito wants to merge 1 commit into
mainfrom
simplify-dispatcher-archive-logic

Conversation

@angulito

@angulito angulito commented Nov 21, 2023

Copy link
Copy Markdown
Contributor

Description

Todo:

  • testing the dispatcher installation works on RDEs
  • inspecting the created zip and double check the created symlinks are correct

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@angulito angulito requested a review from jsedding November 21, 2023 14:13

@jsedding jsedding left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I guess it would be good to add a test showing that symlinks are properly zipped up. Don't really know how to do that in a platform independent fashion, however.

@RemoLiechti RemoLiechti marked this pull request as draft July 29, 2025 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants