Skip to content

Comments

Add support for most recent search type#32

Merged
dompuiu merged 5 commits intomainfrom
add_support_for_most_recent_search_type
May 27, 2025
Merged

Add support for most recent search type#32
dompuiu merged 5 commits intomainfrom
add_support_for_most_recent_search_type

Conversation

@dompuiu
Copy link
Member

@dompuiu dompuiu commented Apr 16, 2025

Description

For the new AJO disqualification feature, we need to support the new mostRecent search type. From a list of events, the mostRecent needs to return the index of the most recent event.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@dompuiu dompuiu requested a review from carterworks April 16, 2025 16:09
@dompuiu dompuiu self-assigned this Apr 16, 2025
@coveralls
Copy link

coveralls commented Apr 16, 2025

Pull Request Test Coverage Report for Build 14667216781

Details

  • 36 of 38 (94.74%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 88.189%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/historical.ts 26 28 92.86%
Totals Coverage Status
Change from base Build 14317909451: 0.3%
Covered Lines: 799
Relevant Lines: 925

💛 - Coveralls

@dompuiu dompuiu merged commit 81fa170 into main May 27, 2025
3 checks passed
@dompuiu dompuiu deleted the add_support_for_most_recent_search_type branch May 27, 2025 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants