Use new event history format needed for AJO disqualification feature.#31
Merged
Use new event history format needed for AJO disqualification feature.#31
Conversation
Member
Author
|
@aenascut If you have time, could you take a look at this PR to see if I don't break anything on your side? While we touched just the historical condition, which from my understanding you are not using, I added a rulesEngineOptions parameter, because we need to provide the rules engine a hashing method. |
Pull Request Test Coverage Report for Build 14271199212Details
💛 - Coveralls |
carterworks
approved these changes
Apr 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The event history in Web SDK was not able to handle all scenarios for the AJO disqualification feature. Previously, the event history was having the format:
The new event history format looks like this:
Main differences are that we hash now the activityId and the eventType. On the hash we store all the events timestamps.
Now related to the changes in this PR.
eventIdandeventType. The rules engine events have the keysiam.idandiam.eventType.I also changed the testing framework from
jesttovitest. When I was trying to debug some tests failures, jest was throwing errors because babel typescript transformation was not happening for an unknown reason. With vitest, it worked beautifully.Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: