Add support to convert column control to responsive node and process responsiveGrid#233
Open
asamaraie wants to merge 1 commit intoadobe:mainfrom
Open
Conversation
- recursive call to find other column controls in the page and process them. - find the column start, break and end nodes and copy the content accordingly
Author
Contributor
|
Need unit tests for this. |
Contributor
|
Just out of curiosity, what drove you to needing this change? working on a project or? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Due to how the rewriting a tree functions, when using the Responsive logic, the parent node order is not preserved. There becomes a conflict between the Column Control order being overwritten by the tree traversal.
Need to find a way to apply the Responsive handling for the Column Control rewriter, without losing the order.
Changes
Related Issue
Support responsiveGrid
Motivation and Context
I noticed that the current column control conversion OSGI configuration doesn't support the responsiveGrid. I added it back to allow users to use it instead of creating new columns if they choose to. It also support having multiple column controls in the page and process them correctly now. previously it was only process one column control that exist in the page
How Has This Been Tested?
I test this locally by using the all-in-one conversion.
Screenshots (if appropriate):
Types of changes
Checklist: