Display editable template options to convert to for each page#20
Open
mickleroy wants to merge 1 commit intoadobe:developfrom
Open
Display editable template options to convert to for each page#20mickleroy wants to merge 1 commit intoadobe:developfrom
mickleroy wants to merge 1 commit intoadobe:developfrom
Conversation
Author
|
@bstopp could you please take a look at this? Thanks |
| return pageRules.stream() | ||
| .filter(rule -> rule.getStaticTemplate().equals(staticTemplate)) | ||
| .map(PageStructureRewriteRule::getEditableTemplate) | ||
| .collect(Collectors.toSet()); |
There was a problem hiding this comment.
did you consider orderable set to present results always in the same order?
Author
There was a problem hiding this comment.
I don't think the order is particularly sensitive in this context. Users can always change the ordering of rows using the table controls in the UI.
Contributor
|
Realizing i'm very late to this, this seems useful, But i think that users may get confused by multiple entries in the list. I'd prefer if the Editable Template column was a drop-down in which they could select which should be used. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an implementation of the feature request lodged here: #16
With the current tool, when multiple editable template configurations are provided for one classic template, only one is chosen arbitrarily. Instead, the tool can now list the editable template options available and let's the user choose which one should be used.
Example config 1:
Example config 2:
Available Classic pages and corresponding Editable templates:
Selecting a row hides other options: