Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
- Store consent in localStorage only when explicitly granted - Remove consent from storage when denied or revoked - Add debug logging for consent grant and revocation
ramboz
approved these changes
Dec 3, 2025
Contributor
ramboz
left a comment
ramboz
left a comment
There was a problem hiding this comment.
Overall logic looks all good to me.
Just left some suggestions on naming and documentation, but nothing blocking
Comment on lines
267
to
276
| // OPTION 2: Cookiebot | ||
| function setupCookiebotConsent() { | ||
| function handleCookiebotConsent() { | ||
| const preferences = window.Cookiebot?.consent?.preferences || false; | ||
| const marketing = window.Cookiebot?.consent?.marketing || false; | ||
| updateExperimentationConsent(preferences || marketing); | ||
| } | ||
| window.addEventListener('CookiebotOnConsentReady', handleCookiebotConsent); | ||
| window.addEventListener('CookiebotOnAccept', handleCookiebotConsent); | ||
| } |
Contributor
There was a problem hiding this comment.
Nice one! We could add this to the martech plugin as well so it's consistent!
Contributor
Author
There was a problem hiding this comment.
ramboz
reviewed
Dec 3, 2025
Co-authored-by: Julien Ramboz <ramboz@users.noreply.github.com>
github-actions bot
pushed a commit
that referenced
this pull request
Feb 18, 2026
# [1.1.0](v1.0.1...v1.1.0) (2026-02-18) ### Bug Fixes * audience checkpoint name ([9db77eb](9db77eb)) * failing tests following refactoring ([f29dd80](f29dd80)) * fragment content replacement ([638e0db](638e0db)) * fragment experiences are not always picked up by the preview pill ([ddaff54](ddaff54)) * fragment experiences are not always picked up by the preview pill ([163e38e](163e38e)) * only fetch pathname to fix url matching issue ([#38](#38)) ([c9ff2c0](c9ff2c0)) * pill css loading on localhost ([09f8a72](09f8a72)) * regressions from prerendering logic and experimeantation ([e6ba4e0](e6ba4e0)) * remove sampling rate changes as this will be handled directly in the rum library in the future ([eaf73fa](eaf73fa)) * remove sampling rate changes as this will be handled directly in the rum library in the future ([306119b](306119b)) * Support Flexible Parsing ([#37](#37)) ([f7c45aa](f7c45aa)) * update getAllMetadata function ([#33](#33)) ([f6ccbcd](f6ccbcd)) ### Features * Add decoration handler for handling fragment decoration ([#39](#39)) ([5f942a2](5f942a2)) * add fragments support ([b59b6a3](b59b6a3)) * add fragments support ([f0cc4ee](f0cc4ee)) * add support for custom conversion name for experiments ([d09ce89](d09ce89)) * add support for experimentation ([07ace43](07ace43)) * add support for experimentation ([453b598](453b598)) * add support for multiple experiments in the UI ([9ea6ed3](9ea6ed3)) * Central host UI files ([#40](#40)) ([9b4478d](9b4478d)) * prepare data for RUMv2 collection ([7dc74e1](7dc74e1)) * support consent management ([#56](#56)) ([5b7a1a0](5b7a1a0)) * support customized variant name for fragment variants ([#36](#36)) ([9db8662](9db8662)) * Support page level full redirection ([#43](#43)) ([285011f](285011f)) * Supporting Naming Variants in Page Expereimentation ([#31](#31)) ([ae769a2](ae769a2))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: